Fix cleanup iteration in save_sys_modules #8713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating `sys.path`, then if you delete index `i`, all elements >`i` will now be one less than what was put into `enumerate`. So we should remove elements in reverse to prevent indices getting out of sync. When iterating `sys.modules`, then modifying it _may_ break the `.keys()` iterator, so work on a copy of the necessary keys.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ±0 29 suites ±0 10h 59m 42s ⏱️ - 3m 14s For more details on these failures, see this check. Results for commit 7cc808a. ± Comparison against base commit adcb045. |
fjetter
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating
sys.path, then if you delete indexi, all elements >iwill now be one less than what was put intoenumerate. So we should remove elements in reverse to prevent indices getting out of sync.When iterating
sys.modules, then modifying it may break the.keys()iterator, so work on a copy of the necessary keys.pre-commit run --all-files