Move pytest-runner and numpy from setup_requires to install requires in setup.py #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'pytest-runner', | ||
| [p for p in install_requires if p.startswith('numpy')][0] | ||
| ], | ||
| # remove wierd setup_requires to get rid of easy_install |
There was a problem hiding this comment.
Leaving comments here probably just confuses people
|
Is there any chance that you can explicitly try this with the conda-forge feedstock, to make sure that the change here doesn't effect the building of the conda package? |
|
Actually I'm using pip, so I can't be sure that it doesn't affect building conda package. |
javabrett
added a commit
to javabrett/fastparquet
that referenced
this pull request
Feb 20, 2019
This reverts commit 14a6af6. setup.py requires setup_requires including numpy - numpy must be installed before the fastparquet wheel build. The changes made in dask#345 and now reverted can be instead managed through configuration of distutils. Fixes dask#389. Signed-off-by: Brett Randall <javabrett@gmail.com>
martindurant
pushed a commit
that referenced
this pull request
Feb 20, 2019
This reverts commit 14a6af6. setup.py requires setup_requires including numpy - numpy must be installed before the fastparquet wheel build. The changes made in #345 and now reverted can be instead managed through configuration of distutils. Fixes #389. Signed-off-by: Brett Randall <javabrett@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with setup_requires when installing the packages not from pypi (for example in our office we use artifactory instead). When you're doing pip install fastparquet it tries to install packages from setup_requires by easy_install from the default source (pypi) ignoring all the configs. If you don't have access to pypi the setup fails although you do have all the sources for requirements at the artifactory. I've moved packages from setup_requires to install_requires thus they are installed by pip with respect to pip.conf.