Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: bump fsspec to 0.9 #371

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

isidentical
Copy link
Member

0.8 doesn't work with fsspec<0.9 though it is getting installed (and raising errors on import time)

@darkclouder
Copy link

darkclouder commented Apr 6, 2021

Not only that, even version 0.7.2 is broken because of the fsspec==0.9.0 update.

  File ".env/lib/python3.8/site-packages/gcsfs/core.py", line 269, in __init__
    self._session = sync(
  File ".env/lib/python3.8/site-packages/fsspec/asyn.py", line 53, in sync
    raise result[0]
  File ".env/lib/python3.8/site-packages/fsspec/asyn.py", line 20, in _runner
    result[0] = await coro
  File ".env/lib/python3.8/site-packages/fsspec/implementations/http.py", line 25, in get_client
    return aiohttp.ClientSession(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'callback_timeout'

Had to freeze fsspec==0.8.7 to make version 0.7.2 work again.
Please don't use >= versions, but restrict them to major releases.
Since there are breaking changes between 0.8.0 and 0.9.0, I would even say minor releases.

So fsspec>=0.9.0,<0.10.0 ?

@martindurant
Copy link
Member

Given the way that Dask and most related projects have gone, I think it might make more sense to switch to calendar-versioning, and always ensure that fsspec/s3fs/gcsfs are released together.

I think that for a library like this, most changes are "breaking", since the downstream libraries don't care just about the user API, but about the internal details. Note, however, that s3fs and gcsfs tests are run as part of the fsspec CI, so at least we know when updates are required.

@martindurant martindurant merged commit a63102e into fsspec:main Apr 6, 2021
@martindurant
Copy link
Member

NB: you are welcome to submit a similar PR to the conda-forge feedstock for build 1. It is not possible to update the release on pypi, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants