Merge pull request #140 from jcrist/isdir-isfile

Add isdir and isfile

hdfs3/core.py

@@ -291,6 +291,22 @@ def info(self, path):
         _lib.hdfsFreeFileInfo(ctypes.byref(fi), 1)
         return ensure_string(out)
 
+    def isdir(self, path):
+        """Return True if path refers to an existing directory."""
+        try:
+            info = self.info(path)
+            return info['kind'] == 'directory'
+        except EnvironmentError:
+            return False
+
+    def isfile(self, path):
+        """Return True if path refers to an existing file."""
+        try:
+            info = self.info(path)
+            return info['kind'] == 'file'
+        except EnvironmentError:
+            return False
+
     def walk(self, path):
         """ Get all file entries below given path """
         return ([ensure_trailing_slash(ensure_string(path), False)]

hdfs3/tests/test_hdfs3.py

@@ -300,6 +300,25 @@ def test_info(hdfs):
     assert hdfs.info('/')['kind'] == 'directory'
 
 
+def test_isdir_isfile(hdfs):
+    fn = '/tmp/test/a'
+    dir = '/tmp/test'
+    missing = '/tmp/not_a_real_path'
+
+    with hdfs.open(fn, 'wb', replication=1) as f:
+        f.write('a' * 5)
+
+    # isdir
+    assert hdfs.isdir(dir)
+    assert not hdfs.isdir(fn)
+    assert not hdfs.isdir(missing)
+
+    # isfile
+    assert hdfs.isfile(fn)
+    assert not hdfs.isfile(dir)
+    assert not hdfs.isfile(missing)
+
+
 def test_df(hdfs):
     with hdfs.open(a, 'wb', replication=1) as f:
         f.write('a' * 10)