DMVP-0000: Initial PR

[viktoryathegreat]

Terraform generated PR for best practices changes

[github-actions]

💰 Infracost estimate: monthly cost will not change

_{This comment will be updated when the cost estimate changes.}

[what-the-diff]

PR Summary

• Daily update of GitHub-Actions and Terraform Packages
  A new schedule has been put in place with the introduction of the .github/dependabot.yaml file. This will ensure that github-actions and terraform packages are updated every day.

• Enhanced Checks for Branch Names on Pull Requests
  A new addition is the .github/workflows/branch-name-check.yaml file, which enforces certain guidelines on branch names submitted during pull requests. This includes checks to ensure the branch names use specific prefixes, match a predetermined pattern and satisfy length requirements.

• Improved Error Handling in Project Analysis
  The .github/workflows/checkov.yaml and .github/workflows/terraform-test.yaml files have been modified to apply changes to the project's root directory and to continue in case of errors, offering smoother processing of jobs.

• Cost Estimation for Changes
  The new .github/workflows/infracost.yaml file sets up a system for cost estimates. This is triggered every time there is a new pull request or push event, providing financial transparency for made changes.

• Enhanced Checks on Pull Request Titles
  A check system has been implemented in the new .github/workflows/pr-title-checker.yaml file. It verifies that titles of pull requests satisfy certain norms, such as specific prefixes, patterns, and length requirements.

• Inclusion of AWS Credentials
  The .github/workflows/pre-commit.yaml and .github/workflows/tflint.yaml files have been edited to include AWS access and secret key as environment variables. This ensures secure access to AWS services.

• Updated Version of Setup-Node Action
  The .github/workflows/semantic-release.yaml file has been updated to utilize the latest version of setup-node action.

• Addition of Check-YAML as a Pre-Commit Hook
  The .github/workflows/tfsec.yaml and .pre-commit-config.yaml files have been updated to include check-yaml as a pre-commit hook. This helps maintain the quality of the code by detecting potential issues before a commit is made.

[github-actions]

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/infracost.yaml
Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/terraform-test.yaml

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 16

check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

[github-actions]

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/terraform-test.yaml
Fixing .github/workflows/checkov.yaml

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 16

check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/terraform-test.yaml
Fixing .github/workflows/checkov.yaml

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 16

check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed

[github-actions]

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/tflint.yaml
Fixing .github/workflows/terraform-test.yaml
Fixing .github/workflows/checkov.yaml

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/pvc.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/serviceaccount.yaml", line 1, column 16
while scanning a plain scalar
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 5
found unexpected ':'
  in "modules/aws-efs/backup/helm/jobs/charts/base-cronjob/templates/cronjob.yaml", line 1, column 16

check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Detect hardcoded secrets.................................................Passed