Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #44 and crashes on connection errors. #51

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

AnonymouX47
Copy link
Contributor

@AnonymouX47 AnonymouX47 commented Aug 10, 2021

- Only checks for ads towards the end of a track.
- Changed to LBYL since it's better in this case.
- Program exits normally if there's no internet connection upon launch.
- Now waits for network reconnection.
@daspartho
Copy link
Owner

Since there is a possibility of Ad playing if user skips tracks, What you guys think should we implement this?

@AnonymouX47
Copy link
Contributor Author

AnonymouX47 commented Aug 10, 2021

Hmm... true, it needs some thought.

Is there any other potential solution?

@AnonymouX47
Copy link
Contributor Author

AnonymouX47 commented Aug 10, 2021

I guess i should've left the separate PR for connection errors open.

@AnonymouX47
Copy link
Contributor Author

AnonymouX47 commented Aug 10, 2021

I figured out a temporary but workable fix for the exception of skipping tracks.

A keyboard interrupt (Ctrl-C) can be sent to the program to trigger a dialogue that asks if the user wants to skip a track or exit the program.
If the user chooses to skip a track... the program sends the appropriate key signal to automatically do that.

This way, the script handles skipping tracks, hence it can simply go ahead to wait for the new track :)

What do you think?

@AnonymouX47
Copy link
Contributor Author

@daspartho I'll merge this PR now because the script currently is in a completely broken state and then implement the fix above soon.

See issue #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError : 'method' object is not subscriptable
2 participants