Skip to content

Commit

Permalink
v0.8.8 -> v0.8.9 (#214)
Browse files Browse the repository at this point in the history
* Feat #43 - Tag, Link components

* Fix #47 - Fix Link props - both onClick & href are undef (#48)

* Fix #47 - Fix Link props - both onClick & href are undef

Closes #47

* Chore #49- Upgrade Storybook and dependencies (#50)

* Chore #49 - Upgrade sb and deps to 6.0.10

* Chore #49 - Bump up version 0.1.7 --> 0.1.8

* Chore #49 - Add react-jss & update linkColor

* Chore #49 - Add normalize.css

Co-authored-by: Parth Shah <parth@dassana.io>

* feat #38 - Add eslint and fix lint errors & warnings (#39)

* Feat #38 - Add typescript Eslint plugins & .eslintrc.js

* Feat #43 - Tag, Link components

* Fix #47 - Fix Link props - both onClick & href are undef (#48)

* Fix #47 - Fix Link props - both onClick & href are undef

Closes #47

* Chore #49- Upgrade Storybook and dependencies (#50)

* Chore #49 - Upgrade sb and deps to 6.0.10

* Chore #49 - Bump up version 0.1.7 --> 0.1.8

* Chore #49 - Add react-jss & update linkColor

* Chore #49 - Add normalize.css

Co-authored-by: Parth Shah <parth@dassana.io>

* feat #3 - Input field component (#53)

* feat #3  - Create input field component + refactor button component + bump storybook version and fix glob error

Closes #3

* Feat #30 - Toggle and Icon components (#52)

* Feat #30 - Add toggle component, icon component, improved verified labels action

* chore #41 - Add verify labels GitHub action (#42)

* Feat #43 - Tag, Link components

* Fix #47 - Fix Link props - both onClick & href are undef (#48)

* Fix #47 - Fix Link props - both onClick & href are undef

Closes #47

* Chore #49- Upgrade Storybook and dependencies (#50)

* Chore #49 - Upgrade sb and deps to 6.0.10

* Chore #49 - Bump up version 0.1.7 --> 0.1.8

* Chore #49 - Add react-jss & update linkColor

* Chore #49 - Add normalize.css

Co-authored-by: Parth Shah <parth@dassana.io>

* feat #38 - Add eslint and fix lint errors & warnings (#39)

* Feat #38 - Add typescript Eslint plugins & .eslintrc.js

* chore #41 - Add verify labels GitHub action (#42)

* Feat #43 - Tag, Link components

* Fix #47 - Fix Link props - both onClick & href are undef (#48)

* Fix #47 - Fix Link props - both onClick & href are undef

Closes #47

* Chore #49- Upgrade Storybook and dependencies (#50)

* Chore #49 - Upgrade sb and deps to 6.0.10

* Chore #49 - Bump up version 0.1.7 --> 0.1.8

* Chore #49 - Add react-jss & update linkColor

* Chore #49 - Add normalize.css

Co-authored-by: Parth Shah <parth@dassana.io>

* feat #3 - Input field component (#53)

* feat #3  - Create input field component + refactor button component + bump storybook version and fix glob error

Closes #3

* Feat #30 - Toggle and Icon components (#52)

* Feat #30 - Add toggle component, icon component, improved verified labels action

* Bump up version to 0.2.0

* Comment out icon component

* Update package.json

* Update index.ts

* Bump up package.json

* Update package-lock.json

* fix #58 - Address icon, styles, global css, and typescript issues (#59)

* fix #58 - Address icon, styles, global css, and typescript issues

* fix #58 - reorder imports

* Update storybook.test.ts.snap

* fix #58 - Regenerate pacakge-lock from clean reinstall

* fix #58 - Add global styles to storybook preview, move rollup deps to dev dep

* fix #58 - Bump version 0.2.3 --> 0.2.4

Co-authored-by: sam-m-m <sam@dassana.io>

* chore #63 - Update .eslintrc.js (#64)

chore #63 - Update .eslintrc.js (#64)

* feat #61 - Skeleton loader component (#66)

* feat #61 - Skeleton loader component

* feat #61 - Update tests

* feat #61 - Update test descriptions and export skeleton from index

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #65 - Form Component (#67)

* feat #65 - Form Component

* v0.2.4 -> v0.2.5

* feat #71 - Notification component (#72)

* feat #71 - Notification component

* feat #76 - Refactor Form.Button to be Form.SubmitButton (#77)

* feat #76 - Refactor Form.Button to be Form.SubmitButton

Closes #76

* feat #77 - Fix failing snapshot test

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #62 - Table component (#70)

* feat #62 - Table Component

* feat #62 - Upgrade sb 6.0.20 --> 6.0.21

* feat #62 - Bump up version 0.2.8

* feat #79 - Select component (#82)

* feat #79 - Select component

Closes #79

* feat #83 - Add data-test attribute to components (#85)

* feat #83 - Add data-test attribute to components

Closes #83

* chore #83 - Address PR comments

Closes #83

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* Update failing snapshots

* feat #88 - Fix type exports for rollup (#89)

* fix #88 - Fix type exports for rollup

Closes #88

* feat #84 - Radio group component (#91)

* feat #84 - Radio Group Component

Closes #84

* feat #84 - Update skeleton CSS and stories

* feat #91 - Address PR comments

* feat #84 - Fix failing snapshot tests

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #81 - Tree component (#86)

* feat #81 - Create basic Tree component

* feat #81 - Add tests

* feat #81 - Update Tree description

* feat #81 - Add TreeSkeleton & tests

* feat #81 - Change ts TreeDataType to TreeNodeType, upgrade antd@latest

* feat #81 - Fix bug: storyshots failed tests

* feat #81 - Create assets/styles, refac tree prop types, add data-attributes

* feat #81 - Address PR Comments, rebase dev

* feat #81 - Export type OnCheckHandler

* feat #81 - map onCheck args

* feat #81 - Address PR comments, refac onCheck --> onChange

* feat #81 - Update file path for RadioGroup styleguide

* feat #81 - Address PR commets, refac onChange, add FormTree

* feat #81 - Fix snapshot test warning

* feat #81 - Address PR comments

* feat #93 - Tooltip component (#95)

* feat #93 - Tooltip component

Closes #93

* feat #93 - Fix tooltip placement

* feat #93 - Extract out placement options to utils and allow tooltip style customization

* feat #93 - Add dataTag to tooltip trigger

* feat #93 - Use storybook decorator for tooltip story

* Update package.json

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #94 - Popover component (#96)

Closes #94

* Feat #99, #101, #100 - Add new avatar component and enhancements for icon and notification components (#103)

* feat #99 - Avatar component
* feat #100 - Notification component should take in configuration options
* feat #101 - Icon component should render svgs

Closes #99
Closes #100
Closes #101

* feat #92 - Theming (#97)

* feat #92 - Theming

* fix #104 - Fix exported types for table and form

* chore #106 - refac all component exports from default to named, add support for absolute imports (#107)

* chore #106 - Refactor all component exports from default to named and add support for absolute imports

Closes #106

* fix #108 - Fix colors, refac stylguide export (#109)

* Components theming (#121)

* Skeleton theming (#112)

* feat - Input toggle link theming: Revamp input, toggle, link styles (#115)

* feat #113 - Button theming (#117)

* Tooltip popover theming (#118)

* feat #119 - Notifications V2 (#120)

* fix #123 - Fix line height in styleguide (#124)

* chore #127, fix #126: Refac & bug-fix Icon component, bug-fix fieldLabel (#128)

* feat - Add Table row click handler (#131)

* Form enhancements (#134)

* feat #133 - Form enhancements

Closes #133

* fix #136 - Fix package publish github action (#137)

Closes #136

* feat #139 - Add focused prop to FormInput and allow refs to be passed to input (#140)

Closes #139

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #144 - Form Toggle (#145)

* feat #144 - Form Toggle

Closes #144

* Update package.json

* feat #144 - Address PR comments

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #142 - Table refactor (#143)

* feat #147, #148 - Update background colors and avatar styles (#149)

* feat #147 - Update background colors

Closes #147

* feat #148 - Update avatar styles

Closes #148

* fix #151 - Fix form toggle submit (#152)

Closes #151

* chore #154 - Update themes & add new items to styleguide (#155)

* feat #157 - Add field errors to Form.Input (#158)

* feat #157 - Add field errors to form input

Closes #157

* Update package.json

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #159 - Add ColoredDot comp and integrate into Table (#161)

* feat #159 - Add IngestionStatusDot comp & add to Table

* feat #159 - Add stories

* feat #159 - Add Tooltip

* feat #159 - Add tests

* feat #159 - Fix failing snapshots

* feat #159 - Refactor IngestionStatusDot --> ColoredDot

* feat #159 - Add tests

* feat #159 - Add Table pagination prop

* enhance #162 - Table: Auto hide/show pagination based on row count (#163)

* enhance #162 - Table: Auto hide/show pagination based on row count

* enhance #162 - Update FormToggle width

* feat #166 - Form Updates (#167)

* feat #166 - Form Updates

Closes #166

* Update failing snapshots

* feat #166 - Prevent Enter in input from automatically submitting form

* Remove unnecessary tests

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* Update package.json

* fix #169 - Add toggle focus styles (#170)

* feat #171 - Table skeleton loader, fix #173 - Overwrite antd Table styles (#172)

* feat #174 - NotificationV2 updates, chore #175 - Extract out IconButton from WAM (#176)

Closes #174 
Closes #175

* chore #179 - Modal and Wizard components (#180)

Closes #179

* feat #178 - Comps related to filter (#182)

* Fix #187 - Multiselect bug (container always wraps) (#188)

* fix #187 - Refac and clean up code

* fix #187 - Multiselect bug (container always wraps)

* fix #187 - Add popupTriggerClasses prop to Popup

* feat #184 - Table enhancements (#189)

* Editable Input

* feat #184 - Table enhancements

Closes #184

* Add clarifying comments

* feat #184 - Address PR comments

* Update storybook.test.ts.snap

* Add AsyncDeleteButton to sample data

* onBlur should pass through as rest for FormSelect

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #190 - Accordion Component (#191)

* feat #190 - Accordion Component

Closes #190

* Update CollapseButton component name to be more semantically correct

* Update package.json

* Address PR comments

Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Co-authored-by: Parth Shah <68707443+parth-dassana@users.noreply.github.com>

* fix #192 - Fix form async initialValues (#193)

Closes #192

Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Co-authored-by: Parth Shah <68707443+parth-dassana@users.noreply.github.com>

* feat #195 - Chip input component (#196)

* feat #195 - Add ChipInput component

* feat #195 - Refac, clean up code

* feat #195 - Refac, update styles

* feat #195 - Add ChipInput to Form, refac

* feat #195 - Add e.stopPropagation to onKeyDown

* feat #195 - Add defaultValues

* feat #195 - Update tags overflow width

* feat #195 - Update Tag key, update Tag close icon focus styles

* feat #195 - Remove Button

* feat #195 - Add undeleteableTags

* feat #195 - Add validation

* feat #195 - Fix validation bug

* feat #195 - Fix input error border color being overwritten

* feat #195 - Update loading Skeleton

* feat #195 - Add Input addons

* feat #195 - Add addons to Chip, update input styles

* feat #195 - Address PR comments

* feat #195 - Address more PR comments

* feat #195 - Fix error bug

* fix #198 - typescript bug with ChipInput component (#199)

* feat #186 - MultipleChoice component, Refac ShortcutMicrocopy (#201)

* feat #205, fix #206 - IconButton and Popover enhancements (#207)

* feat #205 - IconButton Enhancements

Closes #205

* fix #206 - Destroy popover contents on close

Closes #206

* Add pending state and story

* Update package.json

* feat #205 - Fix styles and improve stories

* Update storybook.test.ts.snap

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* feat #202 - Time input components (#203)

* feat #202 - Add Timezone component

* feat #202 - Add Timezone to form

* feat #202 - Extract out InputSkeleton

* feat #202 - Add TimeInput component

* feat #202 - format and parse time input val

* feat #202 - Add TimeInput to form

* feat #202 - Update outer div/input styles

* feat #202 - Fix bug Select, add dropdown styles

* feat #202 - Update TimeInput styles

* feat #202 - Update stories, fix disabled cell color bug

* feat #202 - Rename timezones.js --> timezones.ts

* feat #202 - Fix import bug

* feat #202 - Disable storyshots for Timezone, update package v

* feat #202 - Bump storybook v

* feat #202 - Address PR comments

* feat #202 - Bump web-utils v

* feat #202 - Fix wizard data type

* feat #202 - Address PR comments

* feat #202 - Fix bug, address more PR comments

* feat #202 - Bump package version

* chore #209 - Add org manager icon (#210)

Closes #209

Co-authored-by: github-actions <github-actions@users.noreply.github.com>

* Update package.json

* Updates related to onboarding (#212)

* chore #213 - Updates related to onboarding

* chore #213 - Bump package v

* chore #213 - Fix FormTimeInput fullWidth prop

Co-authored-by: Sam M <68707128+sam-m-m@users.noreply.github.com>
Co-authored-by: Nancy <68706811+nancy-dassana@users.noreply.github.com>
Co-authored-by: sam-m-m <sam@dassana.io>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
  • Loading branch information
5 people committed Feb 9, 2021
1 parent df2f6de commit d231183
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 9 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dassana-io/web-components",
"version": "0.8.8",
"version": "0.8.9",
"publishConfig": {
"registry": "https://npm.pkg.github.com/dassana-io"
},
Expand Down
31 changes: 24 additions & 7 deletions src/components/Form/FormSubmitButton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,25 @@ import { useFormContext } from 'react-hook-form'
import { useShortcut } from '@dassana-io/web-utils'
import { Button, ButtonProps } from 'components/Button'
import React, { FC, useContext } from 'react'
import {
ShortcutMicrocopy,
ShortcutMicrocopyProps
} from 'components/ShortcutMicrocopy'

export interface FormButtonProps
extends Omit<ButtonProps, 'loading' | 'onClick'> {
isDisabled?: (
formState: FormStateProxy,
formValues: Record<string, any>
) => boolean
renderShortcutMicrocopy?: boolean
shortcutMicrocopyProps?: ShortcutMicrocopyProps
}

const FormSubmitButton: FC<FormButtonProps> = ({
isDisabled,
renderShortcutMicrocopy = false,
shortcutMicrocopyProps,
...rest
}: FormButtonProps) => {
const { handleSubmit, formState, watch } = useFormContext()
Expand All @@ -24,6 +32,7 @@ const FormSubmitButton: FC<FormButtonProps> = ({
const isButtonDisabled = () =>
isDisabled ? isDisabled(formState, watch()) : !isDirty

/* TODO: Refactor to allow for multiple keys */
useShortcut({
additionalConditionalFn: () => !isButtonDisabled(),
callback: handleSubmit(onSubmit),
Expand All @@ -32,13 +41,21 @@ const FormSubmitButton: FC<FormButtonProps> = ({
})

return (
<Button
dataTag='submit-button'
disabled={isButtonDisabled()}
loading={loading}
onClick={handleSubmit(onSubmit)}
{...rest}
/>
<>
<Button
dataTag='submit-button'
disabled={isButtonDisabled()}
loading={loading}
onClick={handleSubmit(onSubmit)}
{...rest}
/>
{renderShortcutMicrocopy && !isButtonDisabled() && (
<ShortcutMicrocopy
{...shortcutMicrocopyProps}
loading={loading}
/>
)}
</>
)
}

Expand Down
3 changes: 3 additions & 0 deletions src/components/Form/FormTimeInput/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ export interface FormTimeInputProps
extends BaseFieldProps,
Omit<TimeInputProps, 'defaultValue' | 'onChange' | 'value'> {
focused?: boolean
fullWidth?: boolean
}

const FormTimeInput: FC<FormTimeInputProps> = ({
label,
labelSkeletonWidth,
focused,
fullWidth,
name,
required,
rules = {},
Expand All @@ -34,6 +36,7 @@ const FormTimeInput: FC<FormTimeInputProps> = ({
<div>
{label && (
<FieldLabel
fullWidth={fullWidth}
label={label}
loading={loading}
required={required}
Expand Down

0 comments on commit d231183

Please sign in to comment.