This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
fix app starting before the bundle has been written #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Mar 23, 2017
juliangruber
added a commit
that referenced
this pull request
Mar 27, 2017
juliangruber
added a commit
that referenced
this pull request
Mar 27, 2017
* choo v5
* fix choo-persist usage
* send -> emit
* standard
* fix models/main-view (now models/welcome)
* fix removing a dat
* fix models/window
* rename models/window -> models/drag-drop
* refactor welcome screen into its own element
* refactor empty state into its own element
* models/repos: fix missing .ready state
* fix header
* decouble dat-manager from choo
* move {pause,resume} from model to dat-manager
* move togglePause from model to dat-manager
* move dbPaused logic to dat-manager completely
* move more logic from model to dat-manager
* standard
* fix bugs found in qa (mostly event names)
* move test monkey patching to lib/
* use choo-* dependencies from npm
* lib/monkeypatch: docs
* style
* style
* fix: properly clean up on app quit #311 (cherry-picked)
* standard (cherry-picked)
* the next release is really going to be 1.1.0 (cherry-picked)
* fix progress indicator in case of 0 incopmlete dats #311 (cherry-picked)
* set a max-width on error modal and fix misaligned checkmark icon (#314)
* bump version number
* fix app starting before the bundle has been written (#313)
* fix metadata not always being updated. closes #233 (#316) (cherry-picked)
* standard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dev we would start the app once the bundle was generated, but didn't wait until it was actually written to disk. Sometimes though, you wouldn't see the current version of it.