-
Notifications
You must be signed in to change notification settings - Fork 6
add live update version of .readManifest #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, digging this
Perhaps one addition we should make is to make sure we clean up the event emitter in case of we stop a |
Great catch! Will add |
Added. The implementation would be simpler though if we had an |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 100% 95.16% -4.84%
==========================================
Files 1 1
Lines 44 62 +18
==========================================
+ Hits 44 59 +15
- Misses 0 3 +3
Continue to review full report at Codecov.
|
travis segfaulted on node 4 which is a known issue, the rest passes |
3.1.0 |
required for dat-ecosystem-archive/dat-desktop#233