Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

add live update version of .readManifest #8

Merged
merged 3 commits into from
Mar 22, 2017

Conversation

juliangruber
Copy link
Contributor

Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, digging this

@yoshuawuyts
Copy link
Collaborator

yoshuawuyts commented Mar 17, 2017

Perhaps one addition we should make is to make sure we clean up the event emitter in case of we stop a dat directly too (e.g. dat.close())? Think we'd start leaking unused emitters otherwise

@juliangruber
Copy link
Contributor Author

Perhaps one addition we should make is to make sure we clean up the event emitter in case of we stop a dat directly too (e.g. dat.close())? Think we'd start leaking unused emitters otherwise

Great catch! Will add

@juliangruber
Copy link
Contributor Author

Added. The implementation would be simpler though if we had an dat.on("close", fn) event. @joehand do you think we could add that?

@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #8 into master will decrease coverage by 4.83%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage     100%   95.16%   -4.84%     
==========================================
  Files           1        1              
  Lines          44       62      +18     
==========================================
+ Hits           44       59      +15     
- Misses          0        3       +3
Impacted Files Coverage Δ
index.js 95.16% <86.36%> (-4.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213d998...1c7c3ae. Read the comment docs.

@juliangruber
Copy link
Contributor Author

travis segfaulted on node 4 which is a known issue, the rest passes

@juliangruber juliangruber merged commit 4f7bc15 into master Mar 22, 2017
@juliangruber
Copy link
Contributor Author

3.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants