Skip to content

Commit

Permalink
Fix issue #507 - Warnings in tests/plotly-charts.ipynb
Browse files Browse the repository at this point in the history
  • Loading branch information
arunkrao committed Jul 21, 2023
1 parent 8f6d4ba commit 55a4bbe
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions datascience/tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -4055,7 +4055,9 @@ def scatter(self, column_for_x, select=None, overlay=True, fit_line=False,
if select is not None:
y_labels = self._as_labels(select)
if len(y_labels) > 1 and group is not None and overlay:
warnings.warn("Group and overlay are incompatible in a scatter")
# warnings.warn("Group and overlay are incompatible in a scatter")
# Warning commented out as fix for issue # 507
# When multiple columns are on the y-axis, overlay will be set to False without any unnecessary warnings
overlay = False

def draw(axis, label, color):
Expand Down Expand Up @@ -4189,7 +4191,9 @@ def iscatter(self, column_for_x, select=None, overlay=True, fit_line=False,
y_labels = self._as_labels(select)

if len(y_labels) > 1 and group is not None and overlay:
warnings.warn("Group and overlay are incompatible in a scatter")
# warnings.warn("Group and overlay are incompatible in a scatter")
# Warning commented out as fix for issue # 507
# When multiple columns are on the y-axis, overlay will be set to False without any unnecessary warnings
overlay = False

if group is not None and fit_line:
Expand Down Expand Up @@ -4513,7 +4517,9 @@ def iscatter3d(self, column_for_x, column_for_y, select=None, overlay=True, fit_
z_labels = self._as_labels(select)

if len(z_labels) > 1 and group is not None and overlay:
warnings.warn("Group and overlay are incompatible in a scatter")
#warnings.warn("Group and overlay are incompatible in a scatter")
# Warning commented out as fix for issue # 507
# When multiple columns are on the z-axis, overlay will be set to False without any unnecessary warnings
overlay = False

if group is not None and fit_line:
Expand Down

0 comments on commit 55a4bbe

Please sign in to comment.