Merge pull request #585 from data-8/ahemani/issue_584

Issue 584: Remove redundant Sequence Check
data-8 · Apr 5, 2023 · cc242fd · cc242fd
2 parents dec4d84 + 50a794c
commit cc242fd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/datascience/util.py b/datascience/util.py
@@ -254,6 +254,4 @@ def is_non_string_iterable(value):
         return False
     if hasattr(value, '__iter__'):
         return True
-    if isinstance(value, collections.abc.Sequence):
-        return True
     return False
diff --git a/tests/test_util.py b/tests/test_util.py
@@ -72,7 +72,7 @@ def test_minimize():
 
 
 def test_minimize_smooth():
-    assert _round_eq(2, ds.minimize(lambda x: (x-2)**2, smooth=True))
+    assert _round_eq(2, ds.minimize(lambda x: (x-2)**2, smooth=True, log=print))
     assert _round_eq([2, 1], list(ds.minimize(lambda x, y: (x-2)**2 + (y-1)**2, smooth=True)))
     assert _round_eq(2, ds.minimize(lambda x: (x-2)**2, 1, smooth=True))
     assert _round_eq([2, 1], list(ds.minimize(lambda x, y: (x-2)**2 + (y-1)**2, [1, 1], smooth=True)))