Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements.txt with all dependencies #301

Closed
wants to merge 3 commits into from

Conversation

jasonyzhang
Copy link
Member

[ ] Wrote test for feature
[ x ] Added changes in the Changelog section in README.md
[ x ] Bumped version number (delete if unneeded)

Changes proposed:
Added all dependencies for datascience so that pip install -r requirements.txt works for new envs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.688% when pulling 3b1966c on jasonyzhang:master into 5eaeb4e on data-8:master.

@papajohn
Copy link
Contributor

For now, datascience is a module used primarily by newcomers, and due to pip defaults, fully declaring the dependencies of datascience has caused newcomers to pip various problems. E.g., attempting to upgrade datascience often leads one to accidentally upgrade matplotlib and scipy. For this reason, we leave out the dependencies that are part of a standard Anaconda build.

I do agree that the dependencies should be listed somewhere, though perhaps not in the requirements.txt file.

@davidwagner
Copy link
Member

Closing as won't-merge per papjohn's comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants