fixed bug with rstrip #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, I'm unsure as to how to test this properly. |
davidwagner
reviewed
Jun 18, 2019
davidwagner
reviewed
Jun 18, 2019
davidwagner
reviewed
Jun 18, 2019
If it doesn't mess up any of the histograms in tests/Charts.ipynb, and fixes the problem in #337, I'd say that we have probably tested it sufficiently. In the long run, we might be able to automate some of the testing for histograms using https://matplotlib.org/devel/testing.html#writing-an-image-comparison-test. |
davidwagner
requested changes
Jun 18, 2019
|
Made all the fixes - thanks for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No] Wrote test for feature
[X] Added changes in the Changelog section in README.md
[X] Bumped version number (delete if unneeded)
Changes proposed:
Fixed the bug as described in #338. Was caused as a side-effect of using rstrip which will truncate a set of characters from the back of a string rather than a substring - causing a label like "proportion" to get truncated to "proporti" because "i" was the first letter not in the set of characters " ,c,o,u,n,t".