Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds exception for Table.with_columns(...) #402

Merged
merged 2 commits into from Jul 15, 2019
Merged

Adds exception for Table.with_columns(...) #402

merged 2 commits into from Jul 15, 2019

Conversation

adnanhemani
Copy link
Member

[X] Wrote test for feature
[X] Added changes to CHANGELOG.md
[X] Bumped version number (delete if unneeded)

Changes proposed:
Closes #333.

davidwagner
davidwagner reviewed Jul 13, 2019
View reviewed changes
setup.py Outdated Show resolved Hide resolved
davidwagner
davidwagner requested changes Jul 13, 2019
View reviewed changes
Copy link
Member

@davidwagner davidwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, except for the change to setup.py!

@adnanhemani
Copy link
Member Author

Changes made!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 75.952% when pulling 8088883 on warn_with_columns into e585ca2 on master.

@davidwagner davidwagner merged commit 24b53e9 into master Jul 15, 2019
@davidwagner davidwagner deleted the warn_with_columns branch July 15, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwagner davidwagner davidwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should detect Table.with_columns() and warn the user
3 participants
@adnanhemani @coveralls @davidwagner