Make Table.copy(shallow=False) a deepcopy #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmstepanek
force-pushed
the
add-copy-docs
branch
from
cf04a31
to
16057ba
Compare
|
Hi @hmstepanek , the code looks good but I think you might have tripped our doctests (check Travis CI). Can you please provide a fix for that? |
Note this change also adds documentation and tests to Table.copy.
hmstepanek
force-pushed
the
add-copy-docs
branch
from
16057ba
to
c1b74ea
Compare
adnanhemani
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for Add documentation as it adds documentation for Table.copy.
This is a fix for Possible bug in copy(shallow=False).