Add docs & tests for Table.set_format #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanhemani
requested changes
Sep 13, 2020
datascience/tables.py
Outdated
| @@ -3052,7 +3219,6 @@ def draw_hist(values_dict): | |||
| #There's a grouping in place but we're only plotting one column's values | |||
| label_not_grouped = [l for l in self.labels if l != group][0] | |||
| axis.set_xlabel(label_not_grouped + x_unit, fontsize=16) | |||
| else: | |||
| @@ -514,7 +514,174 @@ def last(self, label): | |||
| ############ | |||
|
|
|||
| def set_format(self, column_or_columns, formatter): | |||
| """Set the format of a column.""" | |||
| """ | |||
There was a problem hiding this comment.
Could you please add an example of one of the built-in formatter classes near the top of this docstring? Most of the users of our library, I image, would be using these quite frequently.
hmstepanek
force-pushed
the
add-set-format-docs
branch
from
7138790
to
ffca115
Compare
|
I've made the first example use the builtin CurrencyFormatter and also made the custom formatter examples more relatable since the builtin CurrencyFormatter would not be able to handle these cases (since it always prepends the symbol). Also fixed the typo. |
hmstepanek
force-pushed
the
add-set-format-docs
branch
from
ffca115
to
b33c1e5
Compare
41 tasks
adnanhemani
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for Add documentation as it adds documentation for Table.set_format.