Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check Table.groups raises error #594

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add test to check Table.groups raises error #594

merged 1 commit into from
Aug 7, 2023

Conversation

rainearcher
Copy link
Contributor

[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
Add test to check Table.groups with bad label raises a ValueError

@coveralls
Copy link

Coverage Status

coverage: 93.414% (+0.04%) from 93.374% when pulling f4b753d on rainearcher:master into 0fe50f2 on data-8:master.

adnanhemani
adnanhemani approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnanhemani adnanhemani merged commit e3617af into data-8:master Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanhemani adnanhemani adnanhemani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rainearcher @coveralls @adnanhemani