Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for table copy method #601

Closed

Conversation

AlexMuresan
Copy link

@AlexMuresan AlexMuresan commented Sep 22, 2023

[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
Test for Table copy method

Tests that a deep copy is not changed when original table is changed Tests that a shallow copy is changed when the original table is changed

[x] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
Test for Table copy method

Tests that a deep copy is not changed when original table is changed
Tests that a shallow copy is changed when the original table is changed
@adnanhemani
Copy link
Member

Hi, thank you for this - but we already have a test for shallow copy vs regular copy as part of the doctests in the code itself. So this addition to the test suite is not really required. If you feel differently, please let me know why this adds value. Thanks!

@AlexMuresan AlexMuresan deleted the test_table_copy_method branch September 26, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants