Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build instructions mention non-existent files #82

Closed
davidwagner opened this issue Nov 19, 2018 · 3 comments
Closed

Build instructions mention non-existent files #82

davidwagner opened this issue Nov 19, 2018 · 3 comments
Assignees
@choldgraf

Comments

@davidwagner
Copy link
Member

The build instructions in README.md mention "Ensure that a SUMMARY.md file exists..." and suggest running "python scripts/generate_summary_from_folders.py" (see https://github.com/data-8/textbook#building-the-textbook, item 3). There is currently no SUMMARY.md file in the repo, and no scripts/generate_summary_from_folders.py file. Should this step be removed from README.md?
@choldgraf
Copy link
Contributor

Good catch - I'll take another pass and update the instructions. Some stuff may have been missed when we moved to the new build system, thanks for flagging this

@choldgraf choldgraf mentioned this issue Nov 29, 2018
Closed
@choldgraf
Copy link
Contributor

@davidwagner I believe that this has now been resolved, when you get a moment could you double-check that all looks OK?

@davidwagner
Copy link
Member Author

Looks great! Love the new auto-deploy stuff, by the way. Thank you for making this so awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@choldgraf choldgraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@choldgraf @davidwagner