Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename: drop_columns -> drop, rename_columns -> rename #340

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

MarcoGorelli
Copy link
Contributor

In general, most methods which work on columns don't have a _columns suffix:

  • we have DataFrame.assign, not DataFrame.assign_columns
  • DataFrame.select, not DataFrame.select_columns

I suggest just having DataFrame.drop and DataFrame.rename then (it's not like they're ambiguous - we don't have row labels in the standard, so it's not like they can refer to row labels...)

@MarcoGorelli MarcoGorelli merged commit 01f6d94 into data-apis:main Dec 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants