Skip to content

Commit

Permalink
Update conftest.py
Browse files Browse the repository at this point in the history
  • Loading branch information
honno committed May 16, 2023
1 parent 58aef8c commit 0c74fcb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
17 changes: 7 additions & 10 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,13 @@ def pytest_configure(config):
"test_signatures.py::test_buffer_method[cudf-__dlpack__]",
"test_signatures.py::test_buffer_method[cudf-__dlpack_device__]",
# https://github.com/vaexio/vaex/issues/2083
# https://github.com/vaexio/vaex/issues/2093
# https://github.com/vaexio/vaex/issues/2113
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-vaex]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[vaex-pandas]",
# https://github.com/modin-project/modin/issues/6143
# https://github.com/data-apis/dataframe-interchange-tests/pull/21#issuecomment-1495914398
"test_from_dataframe.py::test_from_dataframe_roundtrip[pyarrow.Table-vaex]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[vaex-pyarrow.Table]",
# https://github.com/rapidsai/cudf/issues/11389
"test_column_object.py::test_dtype[cudf]",
# Raises RuntimeError, which is technically correct, but the spec will
# require TypeError soon.
# See https://github.com/data-apis/dataframe-api/pull/74
"test_column_object.py::test_describe_categorical[modin]",
# https://github.com/vaexio/vaex/issues/2113
"test_column_object.py::test_describe_categorical[vaex]",
# https://github.com/modin-project/modin/issues/4687
"test_column_object.py::test_null_count[modin]",
# https://github.com/vaexio/vaex/issues/2121
Expand All @@ -71,9 +63,14 @@ def pytest_configure(config):
"test_column_object.py::test_dtype[vaex]",
# SEGFAULT
"test_from_dataframe.py::test_from_dataframe_roundtrip[pandas-vaex]",
# modin flakiness
# modin flakiness - probably from monkeypatching done in wrappers.py
"test_from_dataframe.py::test_from_dataframe_roundtrip[pandas-modin]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-pandas]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-modin]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-vaex]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[vaex-modin]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-pyarrow.Table]",
"test_from_dataframe.py::test_from_dataframe_roundtrip[pyarrow.Table-modin]",
"test_meta.py::test_frame_equal[modin]",
]
assert not any(case in ci_xfail_ids for case in ci_skip_ids) # sanity check
Expand Down
5 changes: 4 additions & 1 deletion tests/wrappers.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def pandas_frame_equal(df1: pd.DataFrame, df2: pd.DataFrame) -> pd.DataFrame:
mock_to_toplevel=mock_to_pd_df,
from_dataframe=pandas_from_dataframe,
frame_equal=pandas_frame_equal,
# https://github.com/pandas-dev/pandas/issues/53155
# ¯\_(ツ)_/¯
allow_zero_cols=False,
allow_zero_rows=False,
)
Expand Down Expand Up @@ -279,6 +279,9 @@ def modin_frame_equal(df1: mpd.DataFrame, df2: mpd.DataFrame) -> bool:
# https://github.com/modin-project/modin/issues/4654
NominalDtype.UTF8,
},
# https://github.com/pandas-dev/pandas/issues/53155
# (changes have yet to propagate)
allow_zero_cols=False,
# https://github.com/modin-project/modin/issues/4643
allow_zero_rows=False,
)
Expand Down

0 comments on commit 0c74fcb

Please sign in to comment.