solved pinv bug

data-cleaning · Feb 5, 2016 · 78079d2 · 78079d2
1 parent 8ac3ae1
commit 78079d2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/pkg/NEWS b/pkg/NEWS
@@ -1,4 +1,5 @@
 version 0.1.0.1
+ - bugfix: pinv crashed on matrices with a single s.v. 
  - bugfix: eliminate would sometimes report the wrong number of equalities
  - bugfix: eliminate sometimes crashed because of a mismatch in colnames of history matrix
 

diff --git a/pkg/R/pinv.R b/pkg/R/pinv.R
@@ -40,7 +40,7 @@ pinv <- function(A, eps=1e-8){
   d <- L$d
   i <- abs(d) > eps
   d[i] <- 1/d[i]
-  L$v %*% diag(d) %*% t(L$u)
+  L$v %*% diag(d, nrow=length(d)) %*% t(L$u)
 }
 
 

diff --git a/pkg/tests/testthat/test_pinv.R b/pkg/tests/testthat/test_pinv.R
@@ -18,3 +18,10 @@ test_that("Computing pseudoinverse",{
   expect_equal(pinv(A),Aplus55/55)
 })
 
+test_that("bugfixes",{
+  # this crashed because there's only one s.v. and 'diag' 
+  # reacts differently when presented a single number.
+  pinv(matrix(c(1,-1,0,0,0)))
+
+})
+