Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadShape.fetch() and MutateShape.fetch() should resolve to object | string | number #120

Closed
ntucker opened this issue Aug 6, 2019 · 0 comments · Fixed by #161
Closed

ReadShape.fetch() and MutateShape.fetch() should resolve to object | string | number #120

ntucker opened this issue Aug 6, 2019 · 0 comments · Fixed by #161
Labels
discussion enhancement New feature or request
Milestone
3.0

Comments

@ntucker
Copy link
Collaborator

ntucker commented Aug 6, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Void types are only valid for delete. So we should enforce them in type land.

Describe the solution you'd like
Make Resource.fetch() return type be conditionally based on method passed in. When method is not delete it will be 'object | string | number | boolean'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

[breaking] ReadShape and MutateShape fetch resolve to valid JSON non-void reactive/data-client
1 participant
@ntucker