Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move variables to reusable constant class #22

Closed
terrytangyuan opened this issue May 12, 2020 · 0 comments
Closed

Move variables to reusable constant class #22

terrytangyuan opened this issue May 12, 2020 · 0 comments
Assignees
Projects

Comments

@terrytangyuan
Copy link
Contributor

Variables/strings that appear in multiple places should be moved to a constant class so they can be easier to reuse, e.g.

  • the list of available metrics in core/scatter_plot.py and in metrics/bivariate.py. The doc-strings can point to this constant class directly.
  • Strings that represent file extensions in utilities/load_data.py.
@terrytangyuan terrytangyuan added this to To do in Open Source May 18, 2020
@dvdjlaw dvdjlaw self-assigned this Jul 7, 2020
@dvdjlaw dvdjlaw moved this from To do to In progress in Open Source Jul 8, 2020
Open Source automation moved this from In progress to Done Jul 15, 2020
dvdjlaw added a commit that referenced this issue Jul 20, 2020
* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix nltk find (#155)

* Fix issue link (#153)

* Rename config_context to update_context (#154)

* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix import alias in tests
Sheth108 pushed a commit that referenced this issue Jul 21, 2020
* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix nltk find (#155)

* Fix issue link (#153)

* Rename config_context to update_context (#154)

* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix import alias in tests
truongc2 pushed a commit that referenced this issue Jul 22, 2020
* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix nltk find (#155)

* Fix issue link (#153)

* Rename config_context to update_context (#154)

* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix import alias in tests
truongc2 pushed a commit that referenced this issue Jul 22, 2020
* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix nltk find (#155)

* Fix issue link (#153)

* Rename config_context to update_context (#154)

* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix import alias in tests
truongc2 pushed a commit that referenced this issue Jul 22, 2020
* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix nltk find (#155)

* Fix issue link (#153)

* Rename config_context to update_context (#154)

* Add file extension changes

* Make file type enum private

* Fix unit test to be os independent

* Fix import alias in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Open Source
  
Done
Development

No branches or pull requests

2 participants