Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Removed extra argument in _sizeof_fmt(), fixed modin implementation of s_freq and s_mean, and bumped modin>=0.8.2 #441

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: Removed extra argument in _sizeof_fmt(), fixed modin implementation of s_freq and s_mean, and bumped modin>=0.8.2 #441

wants to merge 3 commits into from

Conversation

truongc2
Copy link
Collaborator

@truongc2 truongc2 commented Dec 15, 2020 •
edited
Loading

Resolves #429
Resolves #440

@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #441 (d98eaa2) into master (56d10d7) will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   90.35%   91.04%   +0.68%     
==========================================
  Files          41       41              
  Lines        1887     1887              
==========================================
+ Hits         1705     1718      +13     
+ Misses        182      169      -13
Impacted Files Coverage Δ
data_describe/core/summary.py 96.66% <100.00%> (+10.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1038a76...c6b0d89. Read the comment docs.

@truongc2 truongc2 added the bug Something isn't working label Dec 16, 2020
@truongc2 truongc2 mentioned this pull request Dec 16, 2020
Open
@truongc2 truongc2 changed the title Removed extra argument in _sizeof_fmt() and fixed modin implementation of s_freq and s_mean Removed extra argument in _sizeof_fmt(), fixed modin implementation of s_freq and s_mean, and bumped modin>=0.8.2 Dec 16, 2020
@truongc2 truongc2 marked this pull request as draft December 22, 2020 02:48
@truongc2 truongc2 changed the title Removed extra argument in _sizeof_fmt(), fixed modin implementation of s_freq and s_mean, and bumped modin>=0.8.2 WIP: Removed extra argument in _sizeof_fmt(), fixed modin implementation of s_freq and s_mean, and bumped modin>=0.8.2 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@truongc2