Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dataset integration tests - Tables, Folders #1391

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Add Dataset integration tests - Tables, Folders #1391

wants to merge 20 commits into from

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

-This is to be opened as a new PR after #1379

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dlpzx and others added 18 commits July 1, 2024 19:08
@dlpzx
Add integration tests for datasets - basic queries and conftest
b188538
@noah-paige
add list + get queries, add persistent datasets, begin create/update/…
45d1407 
…delete tests
@dlpzx
Add integration test role in Environment stack + session in conftest …
cd27097 
…+ aws clients for dataset
@dlpzx
simplified conftests for datasets
d04b525
@noah-paige
create integration role with region in name
5e5507e
@dlpzx
New environment type: IntegrationTests + ssm param with tooling accou…
fa69dde 
…nt id
@dlpzx
Error on cdk add_to_policy
3e19596
@noah-paige
Add filter term include tags datasets
c05de67
@noah-paige
Add sample data and tests for dataset role access
8f2a918
@noah-paige
Add sample data and tests for dataset role access
9b2c711
@dlpzx
Add assume role permissions to codebuild role
2dcd60f
@dlpzx
Add naming checks in clients + create table
c261da7
@dlpzx
Add permissions, confidentiality and commented tests
1e9732b
@dlpzx
revert persistent environment
5ea8b6b
@dlpzx
Fix check_stack_ready in dataset creation
520a34e
@dlpzx
Revert session environment and add tests
972c883
@noah-paige
fix integration role datasets
7b1c942
@noah-paige
Fix presigned URL upload test
d9042dc
@dlpzx dlpzx changed the title Feat/integration tests datasets pt2 Add Dataset integration tests - Tables, Folders Jul 9, 2024
dlpzx added 2 commits July 9, 2024 15:40
@dlpzx
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/int…
928c3aa 
…egration-tests-datasets-pt2

# Conflicts:
#	tests_new/integration_tests/core/environment/global_conftest.py
#	tests_new/integration_tests/modules/s3_datasets/global_conftest.py
#	tests_new/integration_tests/modules/s3_datasets/test_s3_dataset.py
@dlpzx
Uncomment drafted table/folder tests
b633938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noah-paige @dlpzx