Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo, missing @staticmethod in ResourcePolicyRepository method #1439

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jul 30, 2024

Feature or Bugfix

  • Bugfix

Detail

dataall.core.permissions.db.resource_policy.resource_policy_repositories.ResourcePolicyRepository.query_all_resource_policies is missing @staticmethod and is taking session as self.

I am not sure of the implications. Because there are some arguments that can be None it was not failing, but it might not have deleted some permissions

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx added the type: bug Something isn't working label Jul 30, 2024
@dlpzx dlpzx merged commit 9356074 into main Jul 30, 2024
9 checks passed
@dlpzx dlpzx deleted the fix/resource_policy_static_method branch July 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants