modularization: Worksheets modularization #449
Conversation
… into worksheets-modularization
backend/dataall/modules/worksheets/services/worksheet_services.py
Outdated
Show resolved
Hide resolved
backend/dataall/modules/worksheets/services/worksheet_services.py
Outdated
Show resolved
Hide resolved
backend/dataall/modules/worksheets/services/worksheet_services.py
Outdated
Show resolved
Hide resolved
backend/dataall/modules/worksheets/services/worksheet_services.py
Outdated
Show resolved
Hide resolved
|
We can also move/remove |
backend/dataall/modules/worksheets/services/worksheet_services.py
Outdated
Show resolved
Hide resolved
| @@ -1253,18 +1253,6 @@ def upgrade(): | |||
| sa.Column('created', sa.DateTime(), nullable=True), | |||
| sa.PrimaryKeyConstraint('AthenaQueryId'), | |||
| ) | |||
| op.create_table( | |||
There was a problem hiding this comment.
We cannot modify pre-existing alembic migration scripts. If we are going to delete a table we need to create a new script deleting it otherwise nothing gets deleted in the pre-existing deployments
There was a problem hiding this comment.
In a new deployment, all migration scripts are run in order, so the changes will work. But let's say we have a deployment in V1.3, when we upgrade the CodeBuild dbmigration stage runs alembic upgrade (or something similar) and executes the new migration scripts only
There was a problem hiding this comment.
as we discussed, I removed the unnecessary changes from the former migration scripts, and fixed the changes in the latest one
There was a problem hiding this comment.
Looks good, I will try to test the migration scripts, otherwise I think it is good
dlpzx
changed the title
Modularization of Worksheets - Moved Worksheet related code to its own new module - Merged AthenaQueryResult object into Worksheets - Worksheet related permissions moved to new module - Removed worksheet sharing related (unused) code from the entire repo By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Modularization of Worksheets
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.