Sammyteillet/dat 54 aau i can see the drift in a property of (#26)

* feature: add property drift value * feature: add property drift-value
data-drift · May 10, 2023 · 09f9504 · 09f9504
1 parent 799451a
commit 09f9504
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/database/notion_database/repository.go b/database/notion_database/repository.go
@@ -15,6 +15,7 @@ import (
 const PROPERTY_DATADRIFT_ID = "datadrift-id"
 const PROPERTY_DATADRIFT_TIMEGRAIN = "datadrift-timegrain"
 const PROPERTY_DATADRIFT_PERIOD = "datadrift-period"
+const PROPERTY_DATADRIFT_DRIFT_VALUE = "datadrift-drift-value"
 
 var DefaultPropertiesToDelete = []string{"Tags", "Status", "Étiquette", "Étiquettes"}
 
@@ -150,6 +151,7 @@ func AssertDatabaseHasDatadriftProperties(databaseID, apiKey string) error {
 	shouldCreateDatadriftPropertyId := true
 	shouldCreateDatadriftPropertyPeriod := true
 	shouldCreateDatadriftPropertyTimeGrain := true
+	shouldCreateDatadriftPropertyDriftValue := true
 
 	propertiesToDelete := []string{}
 
@@ -164,6 +166,9 @@ func AssertDatabaseHasDatadriftProperties(databaseID, apiKey string) error {
 		if property.Name == PROPERTY_DATADRIFT_TIMEGRAIN {
 			shouldCreateDatadriftPropertyTimeGrain = false
 		}
+		if property.Name == PROPERTY_DATADRIFT_DRIFT_VALUE {
+			shouldCreateDatadriftPropertyDriftValue = false
+		}
 
 		for _, propertyToDelete := range DefaultPropertiesToDelete {
 			propertyExists := property.Name == propertyToDelete
@@ -174,7 +179,7 @@ func AssertDatabaseHasDatadriftProperties(databaseID, apiKey string) error {
 
 	}
 	fmt.Println("hasDatadriftProperty:", shouldCreateDatadriftPropertyId)
-	shouldCreateProperties := shouldCreateDatadriftPropertyId || shouldCreateDatadriftPropertyPeriod || shouldCreateDatadriftPropertyTimeGrain
+	shouldCreateProperties := shouldCreateDatadriftPropertyId || shouldCreateDatadriftPropertyPeriod || shouldCreateDatadriftPropertyTimeGrain || shouldCreateDatadriftPropertyDriftValue
 	if shouldCreateProperties {
 		params := notion.UpdateDatabaseParams{
 			Properties: map[string]*notion.DatabaseProperty{},
@@ -213,6 +218,15 @@ func AssertDatabaseHasDatadriftProperties(databaseID, apiKey string) error {
 			}
 		}
 
+		if shouldCreateDatadriftPropertyDriftValue {
+			params.Properties[PROPERTY_DATADRIFT_DRIFT_VALUE] = &notion.DatabaseProperty{
+				Type: notion.DBPropTypeNumber,
+				Number: &notion.NumberMetadata{
+					Format: notion.NumberFormatNumberWithCommas,
+				},
+			}
+		}
+
 		fmt.Println("Creating property", params)
 		_, err := client.UpdateDatabase(ctx, databaseID, params)
 		if err != nil {
@@ -245,7 +259,7 @@ func AssertDatabaseHasDatadriftProperties(databaseID, apiKey string) error {
 	return err
 }
 
-func UpdateReport(apiKey string, reportNotionPageId string, children []notion.Block) error {
+func UpdateReport(apiKey string, reportNotionPageId string, children []notion.Block, pageProperties *notion.DatabasePageProperties) error {
 	fmt.Println("Updating report", reportNotionPageId)
 	buf := &bytes.Buffer{}
 	ctx := context.Background()
@@ -256,6 +270,10 @@ func UpdateReport(apiKey string, reportNotionPageId string, children []notion.Bl
 	}
 	client := notion.NewClient(apiKey, notion.WithHTTPClient(httpClient))
 
+	_, updateErr := client.UpdatePage(ctx, reportNotionPageId, notion.UpdatePageParams{DatabasePageProperties: *pageProperties})
+	if updateErr != nil {
+		fmt.Println("[DATADRIFT_ERROR]: err during update", updateErr.Error())
+	}
 	existingReport, err := client.FindBlockChildrenByID(ctx, reportNotionPageId, &notion.PaginationQuery{PageSize: 100})
 	if err != nil {
 		return err

diff --git a/reports/reports.go b/reports/reports.go
@@ -17,7 +17,14 @@ func CreateReport(syncConfig common.SyncConfig, KPIInfo common.KPIReport) error
 	reportNotionPageId, _ := notion_database.FindOrCreateReportPageId(syncConfig.NotionAPIKey, syncConfig.NotionDatabaseID, KPIInfo.KPIName, KPIInfo.PeriodId, timeGrain)
 	fmt.Println(reportNotionPageId)
 
+	diffFloat64, _ := KPIInfo.LatestValue.Sub(KPIInfo.InitialValue).Float64()
+
 	params := notion.CreatePageParams{
+		DatabasePageProperties: &notion.DatabasePageProperties{
+			notion_database.PROPERTY_DATADRIFT_DRIFT_VALUE: notion.DatabasePageProperty{
+				Number: &diffFloat64,
+			},
+		},
 		Children: []notion.Block{
 			notion.Heading1Block{
 				RichText: []notion.RichText{
@@ -193,7 +200,7 @@ func CreateReport(syncConfig common.SyncConfig, KPIInfo common.KPIReport) error
 	}
 	params.Children = append(params.Children, children...)
 
-	err := notion_database.UpdateReport(syncConfig.NotionAPIKey, reportNotionPageId, params.Children)
+	err := notion_database.UpdateReport(syncConfig.NotionAPIKey, reportNotionPageId, params.Children, params.DatabasePageProperties)
 	if err != nil {
 		return fmt.Errorf("failed to create page: %v", err)
 	}