Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare cbs anyway summary data #2582

Merged
merged 8 commits into from
Jun 16, 2024
Merged

compare cbs anyway summary data #2582

merged 8 commits into from
Jun 16, 2024

Conversation

atalyaalon
Copy link
Collaborator

@atalyaalon atalyaalon commented Mar 13, 2024

This pr contains a script that compares CBS and anyway summary data.
It compares current CBS research of 2022 that contains years 2020-2022

@atalyaalon atalyaalon force-pushed the compare-cbs-anyway branch 3 times, most recently from aca6ddd to 3fb267c Compare May 21, 2024 16:20
@atalyaalon atalyaalon marked this pull request as ready for review May 26, 2024 10:38
return df_cbs_total


def get_anyway_count():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use get_query(), or get_accidents_stats()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziv17
I wanted to have the option to modify location_accuracy values to generate different results.
However now that we've decided that 1,3,4 are the sub-urban resolutions, I can use the constants you created (Or use one of the functions you've suggested instead)

Copy link
Collaborator

@ziv17 ziv17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar enough with pandas to provide interesting review. I must learn pandas

@atalyaalon atalyaalon merged commit 66e1a3a into dev Jun 16, 2024
3 checks passed
@atalyaalon atalyaalon deleted the compare-cbs-anyway branch June 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants