Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data frame case sensitivity is not carried over after Merge Transform is applied #145

Closed
yakshpatell opened this issue Jun 21, 2022 · 3 comments

Comments

@yakshpatell
Copy link

This is a very similar issue to an earlier resolved issue but this time, with a different transform: MERGE.

The merge transform does not support case sensitivity. We have multiple customers requesting this feature in our application so if you could add this support, I would greatly appreciate it.

Example:

const frame1 = new DataFrame({
columnNames: ['Name'],
caseSensitive: true
});

const frame2 = new DataFrame({
columnNames: ['name'],
caseSensitive: true
});

const frame3 = frame1.merge(frame2);
console.log('column names: ' + JSON.stringify(frame3.getColumnNames()))

/* ^ logging returns ["Name.1","name.2"] */
@ashleydavis
Copy link
Member

Thanks for your feedback.

This issue happens because the DataFrame that is created in the merge function is case insensitive by default:

image

We could make it case sensitive by just adding that field:

image

However, there are cases where this might not be desired.

I would suggest that we make the result case sensitive if any of the input data frames is case sensitive, like this:

image

This would solve your problem and hopefully not cause an issue for anyone relying on it already.

@yakshpatell
Copy link
Author

yakshpatell commented Jun 23, 2022

Ahh ok. This makes sense. Thank you for the neat step by step explanation!! Really appreciate it.

This change looks good to me. When can I expect this code enhancement to be pushed ? :))

@ashleydavis
Copy link
Member

This issue is fixed in v1.9.6.

The merge function now returns a case sensitive dataframe when any of the input dataframes is case sensitive.

Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants