Skip to content
This repository has been archived by the owner on Mar 17, 2020. It is now read-only.

Commit

Permalink
Merge pull request #4 from data-provider/v1.4.1
Browse files Browse the repository at this point in the history
V1.4.1
  • Loading branch information
javierbrea committed Nov 24, 2019
2 parents 2b9c107 + 1dfb9c1 commit 6160fba
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Removed
### BREAKING CHANGES

## [1.4.1] - 2019-11-24
### Fixed
- Fix Sonar code smell

## [1.4.0] - 2019-11-24
### Changed
- Upgrade @data-provider/core dependency
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@data-provider/connector-react",
"version": "1.4.0",
"version": "1.4.1",
"description": "React connector for Data Provider",
"keywords": [
"data-provider",
Expand Down
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
sonar.organization=data-provider
sonar.projectKey=data-provider-connector-react
sonar.projectVersion=1.4.0
sonar.projectVersion=1.4.1

sonar.sources=src,test,demo/mocks,demo/src
sonar.exclusions=node_modules/**
Expand Down
4 changes: 2 additions & 2 deletions src/connect.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import React from "react";
import hoistNonReactStatics from "hoist-non-react-statics";
import { isEqual } from "lodash";
import { ServerSideDataContext } from "./ServerSideDataContext";
import { error } from "./utils";
import { logError } from "./utils";

const READ_METHOD = "read";

Expand Down Expand Up @@ -133,7 +133,7 @@ export const connect = (mapProvidersToProps, parseProps) => {
}

logError(id, message) {
error(`Error "${message}" in instance "${id}"`);
logError(`Error "${message}" in instance "${id}"`);
}

markProviderAsLoaded(key) {
Expand Down
2 changes: 1 addition & 1 deletion src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export const message = text => {
return `@data-provider/connector-react: ${text}`;
};

export const error = text => {
export const logError = text => {
console.error(message(text));
};

Expand Down

0 comments on commit 6160fba

Please sign in to comment.