implemented map view and example list of markers #40
Conversation
| function EventMapView({ events }) { | ||
|
|
||
| // Example list of events | ||
| events = [ |
There was a problem hiding this comment.
Can we indent all the code 2 spaces. I don't have the linter set up to enforce style yet, but right now the could is many indented 2 spaces.
There was a problem hiding this comment.
In general, it is not good practice to reassign a variable passed in as a prop. Can we rename this variable for now. Maybe something like const mockEvents for now and use them in the component below. Then I think we'll be good to merge and iterate on this component in a separate pull request. Thanks!
There was a problem hiding this comment.
@cdvchek, thanks for pushing up this pull request! Overall, this code looks good. I have two nits on the code. Also, could you give creating a placeholder test for this page?
Don't worry about trying to test the Map rendering. You can just add a placeholder title to make an assertion. See this test for an example. https://github.com/data-umbrella/event-board-web/blob/main/src/__tests__/components/pages/DonatePage.test.jsx
No description provided.