Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datauri 2.0.0 #22

Merged
merged 7 commits into from Apr 17, 2019
Merged

Datauri 2.0.0 #22

merged 7 commits into from Apr 17, 2019

Conversation

heldr
Copy link
Member

@heldr heldr commented Dec 11, 2017

  • Drop support for deprecated and old Node.js versions.
    • 0.12
    • 0.10
  • Remove babel build for module, use only Node.js 4+ code instead.
  • Fix Cannot find module './old/module' #13, since none file is compiled into /lib/old folder
  • Possibly fix Cannot use within webpack #20, since #!/usr/bin/env node only runs in cli script.
  • Update dependencies to avoid warnings and bring security patches.

@SamBroner
Copy link

Is there any progress on this PR?

@heldr
Copy link
Member Author

heldr commented Jun 20, 2018

Not yet, I've been very busy with work. Gonna check ASAP!

@deadcoder0904
Copy link

Hey @heldr I think it can be published? Are there any issues in the PR that can't be published?

I am getting an error due to the # shebang sign as I'm using it with Electron & Webpack. I would really appreciate if you can publish 2.0 :)

@deadcoder0904
Copy link

Also, I guess there is a mistake in the PR. bin in package.json is pointing to index.js whereas its in ./src/index.js I guess

@heldr
Copy link
Member Author

heldr commented Apr 16, 2019

@deadcoder0904 Thanks for catching it and sorry for the big delay.

Gonna fix conflicts too and merge down this version.

@heldr heldr merged commit 63d1e65 into master Apr 17, 2019
@heldr heldr deleted the datauri-2 branch April 17, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use within webpack Cannot find module './old/module'
3 participants