Update redis. #415
Merged
Update redis. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.2.0 has an issue we are observing. 3.2.1 supposedly fixed it. So in theory, it should fix #412
hardbyte
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2.0 has an issue we are observing. 3.2.1 supposedly fixed it.
So in theory, it should fix #412
After running few times the 1M*1M benchmark, it seems to have solved the issue:
it was observed after 7 or so hours of run, but after 8 hours or so with change, it didn't occur.
And based on redis/redis-py#1144 it should have fixed it.