Make sentinel name configurable #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wilko77
requested changes
Sep 26, 2019
hardbyte
force-pushed
the
refactor-cache
branch
from
8de09a5
to
f4ee78a
Compare
hardbyte
force-pushed
the
feature-configurable-sentinel-name
branch
from
9d049b4
to
234bab8
Compare
wilko77
approved these changes
Sep 26, 2019
hardbyte
force-pushed
the
refactor-cache
branch
from
f4ee78a
to
3c46532
Compare
hardbyte
force-pushed
the
feature-configurable-sentinel-name
branch
from
234bab8
to
b55167b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Wilko pointed out in #430 (comment) all the other redis settings are fully configurable except for the sentinel name. This fixes this poor state of affairs.