-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature similarity groups #464
Conversation
Note that the tutorial does not work as long as the deployed entity-service is not updated with the current changes.
And move some changelogs line to the next version instead of the last alpha release as they have not been integrated in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned about the size of the output. By wrapping every sim score in a json object, we would almost double the amount of characters in the output.
I think we should go with something more streamlined. I made a suggestion in the comments, happy to discuss.
👍 for keeping the changelog up to date.
Change everything based on Wilko's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments.
But have a look at the permutation notebook test. Something is not right.
The tutorials are currently faliing because of the newest release of clkhash which has some breaking changes. |
…nto feature-similarity-groups
They may not work with the currently deployed service because of breaking changes.
@wilko77 Since your review, I simply merged dev into this branch (resolving some conflicts in a tutorial), and added a note about the tutorials usage, mainly because the ones from this branch are NOT working with the currently deployed service (because of some breaking change in the code which has not been deployed). |
This is a first step to have the similarity score output for multi-party: this PR modifies the output from
to
which follows the
groups
output format of the candidate pairs (i.e. a record is represented by two indices[party_id, row_index]
.