Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature create blocking project #470

Merged
merged 6 commits into from
Jan 17, 2020
Merged

Conversation

wilko77
Copy link
Collaborator

@wilko77 wilko77 commented Jan 15, 2020

This historic PR marks the beginning of blocking support in the entity service.

I added the flag 'uses_blocking' to the project. This can be set at creation, and will be reported in the ProjectDescription. Internally, this is stored as a flag in the project table in the database.

The idea is that all following actions will consult the DB to decide how to handle data upload, candidate creation and solving...

@wilko77 wilko77 requested a review from joyceyuu January 15, 2020 04:54
Copy link
Contributor

@joyceyuu joyceyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! It is neat and clear! I will make an issue in anonlink to reflect the change in CLI tool. It would be good to fix these errors before merging with master:

UPGRADE FAILED

  • Error: incompatible versions client[v2.16.1] server[v2.15.1]
  • Error: UPGRADE FAILED: incompatible versions client[v2.16.1] server[v2.15.1]

@wilko77 wilko77 merged commit 2420986 into develop Jan 17, 2020
@wilko77 wilko77 deleted the feature-create-blocking-project branch January 17, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants