-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates production deployment documentation. #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the comments. There are some tests failing...
|
||
Minimal Deployment | ||
------------------ | ||
|
||
To run with minikube for local testing we have provided a ``minimal.yaml`` file that will | ||
set very small resource limits. Install the minimal system with:: | ||
To run with minikube for local testing we have provided a ``minimal.yaml`` configuration file that will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is that minimal.yaml
file? I couldn't find it in the deployment folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I would have sworn there was one. I'll remove the reference as it was so minimal it couldn't do much except deploy the service
imagePullPolicy: Always | ||
env: | ||
- name: ENTITY_SERVICE_URL | ||
value: https://beta.anonlink.data61.xyz/api/v1 | ||
value: https://anonlink.easd.data61.xyz/api/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we define the server differently to the benchmark yaml? Is there a reason for this inconsistency?
Wouldn't it be nicer if they both accepted the same name/value pair?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure would be -> #475
@@ -15,11 +15,11 @@ spec: | |||
restartPolicy: Never | |||
containers: | |||
- name: entitytester | |||
image: quay.io/n1analytics/entity-app | |||
image: data61/anonlink-app:v1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be better to link to latest
or stable
or something similar. We don't want to update the deployment files with every release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, happy to use latest
. It is mostly there as an example, and pinning exact versions of what runs is considered best practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the log level setting from here too - it is just for the logging level during tests which pytest overrides anyway.
Thanks for the review @wilko77 - have addressed the inconsistencies in the documentation and opened an issue for the env var. |
2da4f50
to
8ac9447
Compare
This started as just updating a dead hyperlink but has ended up being misc updates to the Kubernetes deployment docs.
Closes #471