Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 472 #477

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix 472 #477

merged 1 commit into from
Feb 5, 2020

Conversation

hardbyte
Copy link
Collaborator

@hardbyte hardbyte commented Feb 4, 2020 •
edited
Loading

@hardbyte hardbyte requested a review from wilko77 February 4, 2020 23:04
@hardbyte hardbyte marked this pull request as ready for review February 4, 2020 23:04
wilko77
wilko77 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I wonder why we didn't see those problems earlier. The code was a bit fragile...

@hardbyte hardbyte merged commit 7d6cb16 into develop Feb 5, 2020
@hardbyte hardbyte deleted the fix-472 branch February 5, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilko77 wilko77 wilko77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardbyte @wilko77