Cleanup docker compose #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
force-pushed
the
cleanup-docker-compose
branch
from
2fad063
to
9934809
Compare
wilko77
approved these changes
Mar 26, 2020
| @@ -54,18 +58,6 @@ services: | |||
| depends_on: | |||
| - db | |||
|
|
|||
| # The dm admin | |||
| db_admin: | |||
There was a problem hiding this comment.
do we not need the db_admin any more?
There was a problem hiding this comment.
I suspect no one other than myself ever used it. It is useful to see the time queries take and see the locks on the database. Want me to put it in a developer-tools.yml file or something?
| @@ -6,6 +6,7 @@ colorama==0.4.3 # required for structlog | |||
| connexion==2.6.0 | |||
| Flask-Opentracing==1.1.0 | |||
| Flask==1.1.1 | |||
| flower==0.9.3 | |||
There was a problem hiding this comment.
they look pretty 🌹
There was a problem hiding this comment.
flower is a celery monitoring tool - we have an example use in the docker-compose file (commented out).
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.