Fix upload to external store #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge similarity score work into master
Merge into master for release 1.7.3
Release v1.7.4
Release v1.9.0
Release 1.9.1
release 1.9.2
Release v1.9.3 into master
Release v1.9.4
Release 1.10.0
Release v1.11.0
Release with Multiparty Examples
Changes for v1.11.2 into master
Release 1.12.0
Release 1.13.0 beta
# Conflicts: # backend/entityservice/VERSION # deployment/entity-service/Chart.yaml # deployment/entity-service/values.yaml # docs/changelog.rst # docs/conf.py # frontend/VERSION
# Conflicts: # backend/entityservice/encoding_storage.py # backend/entityservice/serialization.py
wilko77
requested changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix some bugs arise when testing encoding and blocks uploads to external object store.
The credentials used to create bucket should be environment credentials with MINIO_ACCESS_KEY and MINIO_SECRET_KEY rather than credentials from clients since it causes access denied error.
The uploaded encodings are not actual bytes but encoded strings. We need to deserialise the encodings properly before appending entity_id which assumes encodings are bytes stream
The uploaded blocks has two elements - blocks and metadata. Pull blocks only when writing to database.
Please review this after merging #563