Build sdist in CI #388
Merged
Build sdist in CI #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 16 16
Lines 792 792
=======================================
Hits 749 749
Misses 43 43 |
joyceyuu
approved these changes
Dec 15, 2020
| - '*' | ||
| tags: | ||
| include: | ||
| - v* |
There was a problem hiding this comment.
Why do we need a tag starting with v? Is this pipeline only for release?
There was a problem hiding this comment.
the release pipeline is triggered by the build pipeline. In the past, we didn't execute the build pipeline when a tag is set, thus, the release pipeline was never automatically triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a stage to the CI that builds the source distribution and publishes it to the 'drop' artifact.
And modified the publish to test feed section to include the source dist.
Currently, the release pipeline only publishes the wheel files. We also need to publish the source distribution though.
Additionally, the source distribution was incomplete, as the manifest file was not up to date.
And to round it all off, I also updated the ubuntu images in the CI script, as 16.04 is quite old now. (fixes #385)