fix bugs #21
Merged
fix bugs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FHoffmannCode
commented
Oct 19, 2020
FHoffmannCode
commented
- Pin Werkzeug to be above or equal v0.15.0 - earlier versions are bugged.
- Read configuration in dbnd module setup.py - previously configuration was ignored which could result in version mismatch between dbnd-airflow and dbnd modules.
- Fix issue in Dockerfile.dev where setup.cfg was not copied properly
- Add packaging dependency in dbnd-airflow. This 3rd party package has already been used in this module so this could potentially lead to import error.
- Install airflow related plugins in Dockerfile.
* Pin Werkzeug to be above or equal v0.15.0 - earlier versions are bugged. * Read configuration in dbnd module setup.py - previously configuration was ignored which could result in version mismatch between dbnd-airflow and dbnd modules. * Fix issue in Dockerfile.dev where setup.cfg was not copied properly * Add packaging dependency in dbnd-airflow. This 3rd party package has already been used in this module so this could potentially lead to import error. * Install airflow related plugins in Dockerfile.
FHoffmannCode
requested review from
turbaszek,
evgenyshulman and
jonathanshir
jonathanshir
approved these changes
Oct 19, 2020
evgenyshulman
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Pin Werkzeug to be above or equal v0.15.0 - earlier versions are bugged. * Read configuration in dbnd module setup.py - previously configuration was ignored which could result in version mismatch between dbnd-airflow and dbnd modules. * Fix issue in Dockerfile.dev where setup.cfg was not copied properly * Add packaging dependency in dbnd-airflow. This 3rd party package has already been used in this module so this could potentially lead to import error. * Install airflow related plugins in Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.