hide parameter value in logs and tracking on demand #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHoffmannCode
requested review from
evgenyshulman,
turbaszek and
jonathanshir
FHoffmannCode
force-pushed
the
mask_parameters
branch
from
cb96f91
to
6ec504c
Compare
jonathanshir
approved these changes
Oct 20, 2020
FHoffmannCode
force-pushed
the
mask_parameters
branch
from
6ec504c
to
b7030c4
Compare
* add `hidden` attr to `ParameterDefinition` * hide parameter value if needed in TaskBanner and TaskRunParamInfo * fix misleading type hint * add tests
FHoffmannCode
force-pushed
the
mask_parameters
branch
from
b7030c4
to
d9b41ea
Compare
jonathanshir
approved these changes
Oct 21, 2020
evgenyshulman
approved these changes
Oct 21, 2020
evgenyshulman
pushed a commit
that referenced
this pull request
Oct 27, 2020
* add `hidden` attr to `ParameterDefinition` * hide parameter value if needed in TaskBanner and TaskRunParamInfo * fix misleading type hint * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hiddenattr toParameterDefinitionvalue_to_trackproperty toParameterValuevalue_to_trackproperty whenever tracker wants to readvalueof parameter