-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow google-auth, google-api-python-client < 3 #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing references to predict_wine_quality from integration tests
Remove embeded grafana views from Databand UI In cloud environments we are already disabling Grafana button. We want this to become a default configuration in all environments https://app.asana.com/0/1199880094608584/1200803275263019
…ing auto generating dbnd token
delete the duplicated `log_metrics` function, that was duplicated while rebase and merge of 2 commit
* add a DbndExternalLog model to store all the exceptions * expend capture_monitor_exception to call log_exception in case of exception
# Conflicts: # dbnd-core/CHANGELOG.md
# Conflicts: # dbnd-core/CHANGELOG.md # modules/dbnd-web/src/dbnd_web/services/datasource/__init__.py # modules/dbnd-web/src/dbnd_web/services/datasource/datasource_transaction.py # modules/dbnd-web/src/dbnd_web/services/datasource/repository/transaction.py
# Conflicts: # modules/dbnd-datasource-monitor/setup.py # setup.cfg
Bump gradle version.
# Conflicts: # modules/dbnd-web-app/src/api/mappers/DatasetOperationMapper.js # modules/dbnd-web-app/src/components/data/schema/DataSchemaPreviewDialog.vue # modules/dbnd-web-app/src/pages/data/Datasets/DatasetOperationList.vue
send exceptions happening in the sdk due to dbnd issues
* add tracing uuid to api calls * save the tracing id in the exceptions and events logging tables * adjust the airflow monitor exception logging and the even logging accordingly https://app.asana.com/0/0/1200913339367184/f
* Airflow scheduler generation, * run in run * preview of values * heartbeat mechanism
* deprecating config parameters not in use (tracking_with_cache) * grouping relevant parameters in RunConfig
e26b1a3
to
d8dac3b
Compare
evgenyshulman
pushed a commit
that referenced
this pull request
Dec 7, 2023
* fix * fix * fix Co-authored-by: Maayan Strassberg <maayan.strassberg@databand.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification for
google-auth
google-auth
recently published a 2.0.0 release which removed support for Python 2.7.google-auth
now requires Python >=3.6. No other breaking changes were made. You can see the full list of changes here.I am opening PRs to expand google-auth version ranges for packages that meet either of the following criteria:
google-auth
is a dependency of many different libraries that interact with Google APIs. Increasing the time and number of packages with compatible pins ongoogle-auth
lowers the chance end developers who use multiple libraries will see dependency conflicts.If possible, please do not require
google-auth>2.0.0
until this issue is resolvedgoogleapis/google-cloud-python#10566, as that will further reduce the likelihood of diamond dependency conflicts.
Googlers, see this doc for more information.
Justification for
google-api-python-client
Code written against 1.x.x versions of google-api-python-client is compatible with 2.x.x versions. A full list of changes are described in this document.
Notable changes:
Similar to google-auth, it would be nice to expand the pins on this package if possible to lower the likelihood of dependency conflicts.