Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(protocol): Fix MySQL OK and EOF protocol length condition. #160

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Jul 1, 2022

What is changed and how it works?

Close #157 .
ref: #149 .

What's Changed:

Related changes

  • Fix MySQL OK and EOF protocol length condition.
  • Add unit test for protocol util method.

Signed-off-by: Zonglei Dong <dongzonglei@apache.org>
Signed-off-by: Zonglei Dong <dongzonglei@apache.org>
Signed-off-by: Zonglei Dong <dongzonglei@apache.org>
@dongzl dongzl changed the title Unit test protocol util Chore(protocol): Fix MySQL OK and EOF protocol length condition. Jul 1, 2022
@mlycore mlycore requested a review from xuanyuan300 July 1, 2022 13:23
@mlycore mlycore added this to the v0.2.0 milestone Jul 1, 2022
@mlycore mlycore added app:pisa-proxy Pisa-Proxy related changes in:protocol Protocol related changes labels Jul 1, 2022
@xuanyuan300 xuanyuan300 merged commit 78fafd7 into database-mesh:master Jul 4, 2022
@dongzl dongzl deleted the unit-test-protocol-util branch July 4, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:protocol Protocol related changes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why the MySQL EOF and OK protocol length need add 4?
3 participants