Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(parser): add create tablespace sql parser. #259

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Aug 12, 2022

What is changed and how it works?

ref #61

What's Changed:

Related changes

  • add create tablespace sql parser.
  • add create tablespace sql parser test case.

Signed-off-by: Zonglei Dong <dongzonglei@apache.org>
Signed-off-by: Zonglei Dong <dongzonglei@apache.org>
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #259 (a34b751) into master (df61eb4) will increase coverage by 3.32%.
The diff coverage is 79.68%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   66.97%   70.30%   +3.32%     
==========================================
  Files           7        6       -1     
  Lines         427      495      +68     
==========================================
+ Hits          286      348      +62     
- Misses        133      137       +4     
- Partials        8       10       +2     
Flag Coverage Δ
unittests 70.30% <79.68%> (+3.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 58.62% <53.84%> (+0.72%) ⬆️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 91.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlycore mlycore self-assigned this Aug 13, 2022
@mlycore mlycore added type:enhancement New feature or request app:pisa-proxy Pisa-Proxy related changes in:parser Parser related changes labels Aug 13, 2022
@mlycore mlycore added this to the v0.3.0 milestone Aug 13, 2022
@mlycore mlycore merged commit 1c6f9c4 into database-mesh:master Aug 13, 2022
@dongzl dongzl deleted the create-tablespace branch October 8, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:parser Parser related changes size/XL type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants