Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharding): fix parse sharding toml config failed #381

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

wbtlb
Copy link
Contributor

@wbtlb wbtlb commented Nov 22, 2022

Signed-off-by: wangbo wangbo@sphere-ex.com

What is changed and how it works?

What's Changed:

  • fix parse sharding toml config failed

Signed-off-by: wangbo <wangbo@sphere-ex.com>
@wbtlb wbtlb added app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes labels Nov 22, 2022
@wbtlb wbtlb added this to the v0.3.2 milestone Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #381 (bb765e0) into master (df61eb4) will increase coverage by 7.70%.
The diff coverage is 84.76%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   66.97%   74.68%   +7.70%     
==========================================
  Files           7        6       -1     
  Lines         427      719     +292     
==========================================
+ Hits          286      537     +251     
- Misses        133      171      +38     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 74.68% <84.76%> (+7.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 94.13% <98.33%> (+2.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuanyuan300
Copy link
Contributor

Good job.

@xuanyuan300 xuanyuan300 merged commit f3fb9af into database-mesh:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants