Add an experimental dbt-sql template #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Dec 15, 2023
libs/template/templates/dbt-sql/template/{{.project_name}}/profile_template.yml.tmpl
Outdated
Show resolved
Hide resolved
lennartkats-db
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
## Changes This enhances the template selection experience a bit as we add more and more built-in templates (like #1051 and #1059): ### New experience: <img width="661" alt="image" src="https://github.com/databricks/cli/assets/58432911/afe3b84d-8a77-47f3-b9c2-f827f7893cd7"> ### Current experience: <img width="265" alt="image" src="https://github.com/databricks/cli/assets/58432911/36f8d568-819f-4920-83b1-fb76109ea3d1"> --------- Co-authored-by: shreyas-goenka <88374338+shreyas-goenka@users.noreply.github.com>
lennartkats-db
changed the title
lennartkats-db
force-pushed
the
dbt-template
branch
from
62a0b69
to
1501298
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 52.53% 52.51% -0.02%
==========================================
Files 308 308
Lines 17160 17175 +15
==========================================
+ Hits 9015 9020 +5
- Misses 7481 7489 +8
- Partials 664 666 +2 ☔ View full report in Codecov by Sentry. |
lennartkats-db
changed the title
lennartkats-db
changed the title
lennartkats-db
changed the title
pietern
approved these changes
Feb 5, 2024
| }, | ||
| "http_path": { | ||
| "type": "string", | ||
| "pattern": "^/sql/.\\../warehouses/[a-z0-9]+$", |
There was a problem hiding this comment.
How does this pattern work without + or *?
There was a problem hiding this comment.
I'm not sure I understand this question. There is a + in there?
There was a problem hiding this comment.
Or maybe you're referring to the \.\\.. part? That matches a version, like 1.0.
9 tasks
libs/template/templates/dbt-sql/template/{{.project_name}}/README.md.tmpl
Outdated
Show resolved
Hide resolved
libs/template/templates/dbt-sql/template/{{.project_name}}/README.md.tmpl
Outdated
Show resolved
Hide resolved
libs/template/templates/dbt-sql/template/{{.project_name}}/README.md.tmpl
Outdated
Show resolved
Hide resolved
lennartkats-db
force-pushed
the
dbt-template
branch
from
aaec97d
to
e5fb708
Compare
andrewnester
added a commit
that referenced
this pull request
Feb 20, 2024
CLI: * Add support for UC Volumes to the `databricks fs` commands ([#1209](#1209)). Bundles: * Use dynamic configuration model in bundles ([#1098](#1098)). * Allow use of variables references in primitive non-string fields ([#1219](#1219)). * Add an experimental default-sql template ([#1051](#1051)). * Add an experimental dbt-sql template ([#1059](#1059)). Internal: * Add fork-user to winget release workflow ([#1214](#1214)). * Use `any` as type for data sources and resources in `tf/schema` ([#1216](#1216)). * Avoid infinite recursion when normalizing a recursive type ([#1213](#1213)). * Fix issue where interpolating a new ref would rewrite unrelated fields ([#1217](#1217)). * Use `dyn.Value` as input to generating Terraform JSON ([#1218](#1218)). API Changes: * Changed `databricks lakehouse-monitors update` command with new required argument order. * Added `databricks online-tables` command group. OpenAPI commit cdd76a98a4fca7008572b3a94427566dd286c63b (2024-02-19) Dependency updates: * Bump Terraform provider to v1.36.2 ([#1215](#1215)). * Bump github.com/databricks/databricks-sdk-go from 0.32.0 to 0.33.0 ([#1222](#1222)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
CLI: * Add support for UC Volumes to the `databricks fs` commands ([#1209](#1209)). Bundles: * Use dynamic configuration model in bundles ([#1098](#1098)). * Allow use of variables references in primitive non-string fields ([#1219](#1219)). * Add an experimental default-sql template ([#1051](#1051)). * Add an experimental dbt-sql template ([#1059](#1059)). Internal: * Add fork-user to winget release workflow ([#1214](#1214)). * Use `any` as type for data sources and resources in `tf/schema` ([#1216](#1216)). * Avoid infinite recursion when normalizing a recursive type ([#1213](#1213)). * Fix issue where interpolating a new ref would rewrite unrelated fields ([#1217](#1217)). * Use `dyn.Value` as input to generating Terraform JSON ([#1218](#1218)). API Changes: * Changed `databricks lakehouse-monitors update` command with new required argument order. * Added `databricks online-tables` command group. OpenAPI commit cdd76a98a4fca7008572b3a94427566dd286c63b (2024-02-19) Dependency updates: * Bump Terraform provider to v1.36.2 ([#1215](#1215)). * Bump github.com/databricks/databricks-sdk-go from 0.32.0 to 0.33.0 ([#1222](#1222)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a new dbt-sql template. This work requires the new WorkspaceFS support for dbt tasks.
In this latest revision, I've hidden the new template from the list so we can merge it, iterate over it, and propertly release the template at the right time.
Blockers:
data_security_mode: SINGLE_USERworks on non-UC workspaces (it's required to be explicitly specified on UC workspaces with single-node clusters)Tests